What's new: queries #4058
Merged
What's new: queries #4058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajcvickers
force-pushed
the
CurioQuerio0925
branch
from
b68e119
to
ec2b823
Compare
ajcvickers
force-pushed
the
CurioQuerio0925
branch
from
ec2b823
to
76236fc
Compare
roji
approved these changes
Sep 27, 2022
| Which translates to different SQL: | ||
|
|
||
| ```sql | ||
| SELECT [p].[Id], [p].[AuthorId], [p].[BlogId], [p].[Content], [p].[Discriminator], [p].[PublishedOn], [p].[Title], [p].[PromoText] |
There was a problem hiding this comment.
Huh, I wonder if it makes sense for us to filter on the discriminator with an IN ('Post', 'FeaturedPost') post, rather than fetching everything and filtering on the client...
There was a problem hiding this comment.
We normally filter by the discriminator, but this is a query for the base type (there are only two types in the model) so it's like the OfType isn't there. Perhaps not the best example to show.
There was a problem hiding this comment.
Ohh I see, makes sense. Yeah, using an intermediate hierarchy type may make this clearer.
There was a problem hiding this comment.
Yes, we don't filter anything on client.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.